Skip to content

uv for code checks #21182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 46 commits into from
Closed

uv for code checks #21182

wants to merge 46 commits into from

Conversation

matsumotosan
Copy link
Contributor

@matsumotosan matsumotosan commented Sep 8, 2025 •
edited by github-actions bot
Loading

What does this PR do?

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21182.org.readthedocs.build/en/21182/

matsumotosan and others added 30 commits August 14, 2025 14:22
@matsumotosan
change weights_only default to True
074b01e
@matsumotosan
add docs on weights_only arg
65cc1ed
@SkafteNicki
Merge branch 'master' into weights-only-compatibility
4eaaf58
@matsumotosan
add weights_only arg to checkpoint save. weights_only during test set…
f276114 
… based on ckpt version
@matsumotosan
Merge branch 'master' into weights-only-compatibility
601e300
@matsumotosan
add weights_only arg to checkpoint_io
28f53ae
@matsumotosan
woops, reverting changes
b1cfdf1
@matsumotosan
permissions too
4d96a78
@matsumotosan
fix link
4c39c30
@matsumotosan
fix another link
861d7e0
@matsumotosan
datamodule weights_only args
12bd0d6
@matsumotosan
wip: try safe_globals context manager for tests
5eacb6e
@matsumotosan
add weights_only arg to _run_standard_hparams_test
0430e22
@matsumotosan
weights_only=False when adding extra_args
2abe915
@Borda
Merge branch 'master' into weights-only-compatibility
8e0f61e
@matsumotosan
Merge branch 'master' into weights-only-compatibility
525d9a8
@Borda @matsumotosan
switch to lightning_utilities.cli requirements set-oldest (Lightning-…
83fd824 
…AI#21077)
@Borda @matsumotosan
bump: try deepspeed >=0.14.1,<=0.15.0 (Lightning-AI#21076)
93cbe94 
* try `deepspeed >=0.14.1,<=0.15.0`
* drop from oldest
* pip uninstall -y deepspeed
* error::DeprecationWarning
@matsumotosan
weights_only=True default for torch>=2.6
2a53f2f
@matsumotosan
Merge branch 'master' into weights-only-compatibility
3833892
@matsumotosan
Merge branch 'Lightning-AI:master' into weights-only-compatibility
9d8997e
@matsumotosan
changelog
561c02c
@matsumotosan
ignore torch.load futurewarning
c67c8a3
@matsumotosan
add .*
005c439
@matsumotosan
will this woork
2ab89a2
@matsumotosan
weights_only according pl version
74e5e5a
@matsumotosan
set env var TORCH_FORCE_NO_WEIGHTS_ONLY_LOAD=1 for pl < 1.5.0
a4c9efe
@matsumotosan
weights_only=False for omegaconf hparams test
2c2ab9e
@matsumotosan
default to weights_only=true for loading from state_dict from url
54b859a
@matsumotosan
weights_only=False for hydra
7ddb4f8
matsumotosan and others added 16 commits August 22, 2025 20:20
@matsumotosan
Merge branch 'master' into weights-only-compatibility
7d6174a
@matsumotosan @Borda
Update src/lightning/fabric/utilities/cloud_io.py
906e52e 
Co-authored-by: Jirka Borovec <[email protected]>
@matsumotosan
Merge branch 'Lightning-AI:master' into weights-only-compatibility
377cf11
@Borda
Merge branch 'master' into weights-only-compatibility
9aadbef
@matsumotosan
Merge branch 'master' into weights-only-compatibility
52b3215
@matsumotosan
defaults for weights_only in torch.hub.load_state_dict_from_url
170fbe0
@matsumotosan
default to weights_only=False for torch.hub.load_state_dict_from_url
bf7e284
@Borda
Merge branch 'master' into weights-only-compatibility
a5d6da3
@matsumotosan
Merge branch 'master' into weights-only-compatibility
a3183ba
@matsumotosan
add weights_only to trainer.fit, validate, test, predict
5ac9695
@matsumotosan
fix tests
ea066a9
@matsumotosan
Merge branch 'master' into weights-only-compatibility
6b711c9
@matsumotosan
add weights_only arg
4d65777
@matsumotosan
Merge branch 'master' into weights-only-compatibility
087d467
@matsumotosan
specify weights_only kwarg
b84a53d
@matsumotosan
code check with uv
d756042
@github-actions github-actions bot added ci Continuous Integration fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package package labels Sep 8, 2025
@matsumotosan matsumotosan deleted the uv-for-code-checks branch September 8, 2025 12:57
@codecov Codecov
Copy link

codecov bot commented Sep 8, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87%. Comparing base (f41f73d) to head (d756042).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #21182   +/-   ##
=======================================
  Coverage      87%      87%           
=======================================
  Files         269      269           
  Lines       23656    23660    +4     
=======================================
+ Hits        20635    20640    +5     
+ Misses       3021     3020    -1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

Assignees
No one assigned
Labels
ci Continuous Integration fabric lightning.fabric.Fabric package pl Generic label for PyTorch Lightning package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matsumotosan @SkafteNicki @Borda